⚡️ Speed up _sanitize_tag_value() by 176% in sentry_sdk/metrics.py
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_sanitize_tag_value()insentry_sdk/metrics.py📈 Performance improved by
176%(1.76xfaster)⏱️ Runtime went down from
689 microsecondsto250 microsecondsExplanation and details
Here's an optimized version of the given program.
By using chained
replacecalls, we avoid the overhead of creating a translation table and using thetranslatemethod, which slightly improves the performance, especially for shorter strings.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 24 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests