Fix regression from 6379b473#75
Merged
Merged
Conversation
The server-sig-algs should be Hostkey.preferred_algs, not just the algorithm for the servers host key. That way we can have a server that uses a ed25519 host key and allow authentication with an RSA key.
Member
Member
Author
|
I commented in the commit also. The other usages are for |
Member
Author
|
On the other hand it seems we had an error in rekeying before that commit as we allow (almost) any server host key sig algs when rekeying?! I don't remember how rekeying works, but that seems odd if not wrong. |
Member
Author
|
Reading rfc4253 pp. 14, 22-23 it seems an error. It's possible to change the host keys and the algorithms in a rekey. |
Member
Author
|
It seems I am to blame for suggesting this regression :D #62 (comment) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 5, 2025
CHANGES: * Fix regression from 6379b473 (server-sig-algs should be Hostkey.preferred_algs) (mirage/awa-ssh#75, @reynir) * Avoid functors over Mirage_time.S and Mirage_clock.MCLOCK (mirage/awa-ssh#76 @hannesm) * Adapt to mirage-crypto-rng 1.2.0 (mirage/awa-ssh#76 @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server-sig-algs should be Hostkey.preferred_algs, not just the algorithm for the servers host key. That way we can have a server that uses a ed25519 host key and allow authentication with an RSA key.
Found while testing #74 using awa_test_server.