Client, accept stderr passed via channel extended data#43
Merged
Conversation
Member
|
Looks fine to me, thanks. The "generic" version (and allowing the client to send such data) can be implemented at a later point, if it is needed. I can as well only find usage of type 1 (standard error), the rest seems to be reserved for private use. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jan 19, 2022
CHANGES: * mirage: add server implementation, and ssh subsystem (mirage/awa-ssh#35, @palainp) * client: accept channel extended data (stderr) (@art-w, mirage/awa-ssh#43) * cram test for awa_gen_key and what a user provides (@dinosaure, mirage/awa-ssh#44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing shell commands, the ssh server can send stderr via the extended data channel:
awa-ssh/docs/rfc4254.txt
Lines 412 to 432 in d85a95c
But currently, the awa client fails with an
"unexpected state and message"since it doesn't expect anyMsg_channel_extended_data. Note that this PR only handles theSSH_EXTENDED_DATA_STDERR=1case as I'm not aware of other extensions, but perhaps it should return a generic`Channel_extended_data (id, data_type_code, data)and leave the user to interpret the meaning ofdata_type_code?