Easify list by (default) conditions

Kijewski · Kijewski · commit d2e2e39aca33 · 2014-07-05T23:25:36.000+02:00
I found that the current `pygithub3.services.issues.Issue.list_by_repo`
implementations does not work. Overriding the default parameters did not
seem to work for me.

This PR removes the default parameters. The default parameters don't
need to be passed.
diff --git a/pygithub3/services/issues/__init__.py b/pygithub3/services/issues/__init__.py
@@ -17,8 +17,7 @@ def __init__(self, **config):
         self.milestones = Milestones(**config)
         super(Issue, self).__init__(**config)
 
-    def list(self, filter='assigned', state='open', labels='', sort='created',
-            direction='desc', since=None):
+    def list(self, **params):
         """ List your issues
 
         :param str filter: 'assigned', 'created', 'mentioned' or 'subscribed'
@@ -33,14 +32,10 @@ def list(self, filter='assigned', state='open', labels='', sort='created',
         .. warning::
             You must be authenticated
         """
-        params = dict(filter=filter, state=state, labels=labels, sort=sort,
-            direction=direction)
         request = self.request_builder('issues.list')
         return self._get_result(request, **params)
 
-    def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
-            assignee='*', mentioned='', labels='', sort='created',
-            direction='desc', since=None):
+    def list_by_repo(self, user=None, repo=None, **params):
         """ List issues for a repo
 
         :param str milestone: Milestone ID, 'none' or '*'
@@ -57,8 +52,6 @@ def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
         .. note::
             Remember :ref:`config precedence`
         """
-        params = dict(milestone=milestone, state=state, assignee=assignee,
-            mentioned=mentioned, labels=labels, sort=sort, direction=direction)
         request = self.make_request('issues.list_by_repo', user=user,
             repo=repo)
         return self._get_result(request, **params)
diff --git a/pygithub3/services/issues/milestones.py b/pygithub3/services/issues/milestones.py
@@ -8,8 +8,7 @@ class Milestones(Service):
     """ Consume `Milestones API
     <http://developer.github.com/v3/issues/milestones>`_ """
 
-    def list(self, user=None, repo=None, state='open', sort='due_date',
-            direction='desc'):
+    def list(self, user=None, repo=None, **params):
         """ List milestones for a repo
 
         :param str user: Username
@@ -24,8 +23,7 @@ def list(self, user=None, repo=None, state='open', sort='due_date',
         """
         request = self.make_request('issues.milestones.list', user=user,
             repo=repo)
-        return self._get_result(request, state=state, sort=sort,
-            direction=direction)
+        return self._get_result(request, **params)
 
     def get(self, number, user=None, repo=None):
         """ Get a single milestone
