callbacks revision: allow group lr and correct the logging for resuming training#386
Merged
Conversation
zhtmike
reviewed
Jun 13, 2023
zhtmike
approved these changes
Jun 21, 2023
Songyuanwei
reviewed
Jun 23, 2023
ab50f17 to
0525cd3
Compare
adapt to group lr
Songyuanwei
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
When resuming training, the correct logging should be [cur_epoch/(training_epochs+start_epochs)] to avoid confusion.
It is possible that opt.get_lr() is not a single scalar but a list of scalars. When users pass a list of dictionaries to the optimizer, for example:
The visualization should print each distinct lr.
Test Plan
Related Issues and PRs
NA