fix(query-builder): merge raw join results in qb.execute()#4825
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| switch (prop.reference) { | ||
| case ReferenceType.ONE_TO_MANY: | ||
| case ReferenceType.MANY_TO_MANY: | ||
| map[pk][hint.field] = this.mergeJoinedResult<T>([...map[pk][hint.field], ...item[hint.field]], prop.targetMeta!, hint.children ?? []); |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment
| break; | ||
| case ReferenceType.MANY_TO_ONE: | ||
| case ReferenceType.ONE_TO_ONE: | ||
| map[pk][hint.field] = this.mergeJoinedResult<T>([map[pk][hint.field], item[hint.field]], prop.targetMeta!, hint.children ?? [])[0]; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
qb.execute()method returned cartesian product when joining to-many relations. Now the results will be automatically merged, as if you would map the results viaqb.getResult().Closes #4816
Related #4741