Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mikro-orm/mikro-orm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.8.9
Choose a base ref
...
head repository: mikro-orm/mikro-orm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.8.10
Choose a head ref
  • 10 commits
  • 41 files changed
  • 4 contributors

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    944a44a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    d45e827 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41e38b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    fc32e49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84bf66e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    31edc8d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. fix(reflection): ensure complete stripping of relative paths with mul…

    …tiple leading slashes (#4844)
    
    This PR addresses an issue where relative paths with leading slashes and
    dots were not being stripped correctly. The problem arises when the
    'path' contains multiple leading slashes like `../../`, as the current
    logic strips it to `/../`, which is incorrect and prevents the entity
    from being discovered.
    
    This code modification ensures that any dots followed by slashes are
    stripped to provide the full path without any dots and slashes at the
    beginning.
    
    **Please note:** that the current behavior is such that if you pass
    `./my/path` the result is `/my/path` However, with the updated code, the
    result will be `my/path` This change is made because, in the end, we use
    the resulting path to check if the `source` contains the path using
    `endsWith`, and the leading slash is unnecessary for this purpose.
    
    ## Update
    I added a slash again after @B4nan clarified a case that we need it in
    this
    [thread](https://mikroorm.slack.com/archives/CFTFEK39D/p1697634946389959?thread_ts=1697550457.817269&cid=CFTFEK39D)
    
    so the result now for `./my/path` will be `/my/path`
    AbdlrahmanSaberAbdo authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8a635c7 View commit details
    Browse the repository at this point in the history
  2. chore: remove unused dependency

    B4nan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    6c8c15f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f82e95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a764d2c View commit details
    Browse the repository at this point in the history
Loading