-
-
Notifications
You must be signed in to change notification settings - Fork 638
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: mikro-orm/mikro-orm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.8.9
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: mikro-orm/mikro-orm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.8.10
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 41 files changed
- 4 contributors
Commits on Oct 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 944a44a - Browse repository at this point
Copy the full SHA 944a44aView commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d45e827 - Browse repository at this point
Copy the full SHA d45e827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e38b8 - Browse repository at this point
Copy the full SHA 41e38b8View commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc32e49 - Browse repository at this point
Copy the full SHA fc32e49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84bf66e - Browse repository at this point
Copy the full SHA 84bf66eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31edc8d - Browse repository at this point
Copy the full SHA 31edc8dView commit details
Commits on Oct 18, 2023
-
fix(reflection): ensure complete stripping of relative paths with mul…
…tiple leading slashes (#4844) This PR addresses an issue where relative paths with leading slashes and dots were not being stripped correctly. The problem arises when the 'path' contains multiple leading slashes like `../../`, as the current logic strips it to `/../`, which is incorrect and prevents the entity from being discovered. This code modification ensures that any dots followed by slashes are stripped to provide the full path without any dots and slashes at the beginning. **Please note:** that the current behavior is such that if you pass `./my/path` the result is `/my/path` However, with the updated code, the result will be `my/path` This change is made because, in the end, we use the resulting path to check if the `source` contains the path using `endsWith`, and the leading slash is unnecessary for this purpose. ## Update I added a slash again after @B4nan clarified a case that we need it in this [thread](https://mikroorm.slack.com/archives/CFTFEK39D/p1697634946389959?thread_ts=1697550457.817269&cid=CFTFEK39D) so the result now for `./my/path` will be `/my/path`
Configuration menu - View commit details
-
Copy full SHA for 8a635c7 - Browse repository at this point
Copy the full SHA 8a635c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8c15f - Browse repository at this point
Copy the full SHA 6c8c15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f82e95 - Browse repository at this point
Copy the full SHA 9f82e95View commit details -
Configuration menu - View commit details
-
Copy full SHA for a764d2c - Browse repository at this point
Copy the full SHA a764d2cView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.8.9...v5.8.10