Type cast (int) where PHP8.x was complaining

BorisAnthony · BorisAnthony · commit 0e102667deed · 2023-07-07T22:05:45.000+02:00
PHP's gotten stricter about type juggling and complained that converting from `float` to `int` causes imprecisions and that if one does it, it should be explicit.
Not rigorously tested but seems to have fixed the Warnings in my usage.
diff --git a/src/MischiefCollective/ColorJizz/ColorJizz.php b/src/MischiefCollective/ColorJizz/ColorJizz.php
@@ -110,7 +110,7 @@ public function distance(ColorJizz $destinationColor)
         $a_dimension_pow = pow(($a->a_dimension - $b->a_dimension), 2);
         $b_dimension_pow = pow(($a->b_dimension - $b->b_dimension), 2);
 
-        return sqrt($lightness_pow + $a_dimension_pow + $b_dimension_pow);
+        return (int)sqrt($lightness_pow + $a_dimension_pow + $b_dimension_pow);
     }
 
     /**
diff --git a/src/MischiefCollective/ColorJizz/Formats/CMY.php b/src/MischiefCollective/ColorJizz/Formats/CMY.php
@@ -67,7 +67,7 @@ public static function create($cyan, $magenta, $yellow)
      */
     public function getCyan()
     {
-        return $this->cyan;
+        return (int)$this->cyan;
     }
 
 
@@ -78,7 +78,7 @@ public function getCyan()
      */
     public function getMagenta()
     {
-        return $this->magenta;
+        return (int)$this->magenta;
     }
 
 
@@ -89,7 +89,7 @@ public function getMagenta()
      */
     public function getYellow()
     {
-        return $this->yellow;
+        return (int)$this->yellow;
     }
 
 
diff --git a/src/MischiefCollective/ColorJizz/Formats/CMYK.php b/src/MischiefCollective/ColorJizz/Formats/CMYK.php
@@ -74,7 +74,7 @@ public static function create($cyan, $magenta, $yellow, $key)
      */
     public function getCyan()
     {
-        return $this->cyan;
+        return (int)$this->cyan;
     }
 
 
@@ -85,7 +85,7 @@ public function getCyan()
      */
     public function getMagenta()
     {
-        return $this->magenta;
+        return (int)$this->magenta;
     }
 
 
@@ -96,7 +96,7 @@ public function getMagenta()
      */
     public function getYellow()
     {
-        return $this->yellow;
+        return (int)$this->yellow;
     }
 
 
@@ -107,7 +107,7 @@ public function getYellow()
      */
     public function getKey()
     {
-        return $this->key;
+        return (int)$this->key;
     }
 
     /**
diff --git a/src/MischiefCollective/ColorJizz/Formats/RGB.php b/src/MischiefCollective/ColorJizz/Formats/RGB.php
@@ -72,7 +72,7 @@ public function __construct($red, $green, $blue)
      */
     public function getRed()
     {
-        return (0.5 + $this->red) | 0;
+        return (int)(0.5 + $this->red) | 0;
     }
 
     /**
@@ -82,7 +82,7 @@ public function getRed()
      */
     public function getGreen()
     {
-        return (0.5 + $this->green) | 0;
+        return (int)(0.5 + $this->green) | 0;
     }
 
     /**
@@ -92,7 +92,7 @@ public function getGreen()
      */
     public function getBlue()
     {
-        return (0.5 + $this->blue) | 0;
+        return (int)(0.5 + $this->blue) | 0;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public function distance(ColorJizz $destinationColor)`
`110`	`110`	`$a_dimension_pow = pow(($a->a_dimension - $b->a_dimension), 2);`
`111`	`111`	`$b_dimension_pow = pow(($a->b_dimension - $b->b_dimension), 2);`
`112`	`112`
`113`		`- return sqrt($lightness_pow + $a_dimension_pow + $b_dimension_pow);`
	`113`	`+ return (int)sqrt($lightness_pow + $a_dimension_pow + $b_dimension_pow);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public static function create($cyan, $magenta, $yellow)`
`67`	`67`	`*/`
`68`	`68`	`public function getCyan()`
`69`	`69`	`{`
`70`		`- return $this->cyan;`
	`70`	`+ return (int)$this->cyan;`
`71`	`71`	`}`
`72`	`72`
`73`	`73`
`@@ -78,7 +78,7 @@ public function getCyan()`
`78`	`78`	`*/`
`79`	`79`	`public function getMagenta()`
`80`	`80`	`{`
`81`		`- return $this->magenta;`
	`81`	`+ return (int)$this->magenta;`
`82`	`82`	`}`
`83`	`83`
`84`	`84`
`@@ -89,7 +89,7 @@ public function getMagenta()`
`89`	`89`	`*/`
`90`	`90`	`public function getYellow()`
`91`	`91`	`{`
`92`		`- return $this->yellow;`
	`92`	`+ return (int)$this->yellow;`
`93`	`93`	`}`
`94`	`94`
`95`	`95`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public static function create($cyan, $magenta, $yellow, $key)`
`74`	`74`	`*/`
`75`	`75`	`public function getCyan()`
`76`	`76`	`{`
`77`		`- return $this->cyan;`
	`77`	`+ return (int)$this->cyan;`
`78`	`78`	`}`
`79`	`79`
`80`	`80`
`@@ -85,7 +85,7 @@ public function getCyan()`
`85`	`85`	`*/`
`86`	`86`	`public function getMagenta()`
`87`	`87`	`{`
`88`		`- return $this->magenta;`
	`88`	`+ return (int)$this->magenta;`
`89`	`89`	`}`
`90`	`90`
`91`	`91`
`@@ -96,7 +96,7 @@ public function getMagenta()`
`96`	`96`	`*/`
`97`	`97`	`public function getYellow()`
`98`	`98`	`{`
`99`		`- return $this->yellow;`
	`99`	`+ return (int)$this->yellow;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`
`@@ -107,7 +107,7 @@ public function getYellow()`
`107`	`107`	`*/`
`108`	`108`	`public function getKey()`
`109`	`109`	`{`
`110`		`- return $this->key;`
	`110`	`+ return (int)$this->key;`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function __construct($red, $green, $blue)`
`72`	`72`	`*/`
`73`	`73`	`public function getRed()`
`74`	`74`	`{`
`75`		`- return (0.5 + $this->red) \| 0;`
	`75`	`+ return (int)(0.5 + $this->red) \| 0;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`/**`
`@@ -82,7 +82,7 @@ public function getRed()`
`82`	`82`	`*/`
`83`	`83`	`public function getGreen()`
`84`	`84`	`{`
`85`		`- return (0.5 + $this->green) \| 0;`
	`85`	`+ return (int)(0.5 + $this->green) \| 0;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`/**`
`@@ -92,7 +92,7 @@ public function getGreen()`
`92`	`92`	`*/`
`93`	`93`	`public function getBlue()`
`94`	`94`	`{`
`95`		`- return (0.5 + $this->blue) \| 0;`
	`95`	`+ return (int)(0.5 + $this->blue) \| 0;`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`/**`