ENH: enable subclassing for tours#530
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 93.31% 93.44% +0.13%
==========================================
Files 34 34
Lines 2153 2166 +13
Branches 409 414 +5
==========================================
+ Hits 2009 2024 +15
+ Misses 130 129 -1
+ Partials 14 13 -1
☔ View full report in Codecov by Sentry. |
hongyeehh
reviewed
Sep 19, 2023
Member
hongyeehh
left a comment
hongyeehh
left a comment
There was a problem hiding this comment.
Looks great from my side, just one small docstring question.
hongyeehh
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last class. For reference see #490.