Skip to content

ENH: Store trips list as JSON in postgis#496

Merged
NinaWie merged 1 commit into
mie-lab:masterfrom
bifbof:#443
Jul 30, 2023
Merged

ENH: Store trips list as JSON in postgis#496
NinaWie merged 1 commit into
mie-lab:masterfrom
bifbof:#443

Conversation

@bifbof
Copy link
Copy Markdown
Collaborator

@bifbof bifbof commented Jul 30, 2023

closes #443

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (eb7d6ce) 92.31% compared to head (58f02a9) 92.33%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.01%     
==========================================
  Files          39       39              
  Lines        2004     2008       +4     
  Branches      340      341       +1     
==========================================
+ Hits         1850     1854       +4     
  Misses        133      133              
  Partials       21       21              
Files Changed Coverage Δ
trackintel/io/postgis.py 95.78% <100.00%> (+0.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NinaWie NinaWie self-requested a review July 30, 2023 16:23
Copy link
Copy Markdown
Member

@NinaWie NinaWie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean solution!

@NinaWie NinaWie merged commit 4e76060 into mie-lab:master Jul 30, 2023
@bifbof bifbof deleted the #443 branch July 30, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List of trip ids in a tour dataframe is unstructured when reading it from postgis.

2 participants