ENH: separate read_gpd kwargs into own variable#494
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 39 39
Lines 2004 2004
Branches 340 340
=======================================
Hits 1850 1850
Misses 133 133
Partials 21 21
☔ View full report in Codecov by Sentry. |
NinaWie
reviewed
Jul 30, 2023
Member
NinaWie
left a comment
NinaWie
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! I have a few comments regarding the argument name and the default value, which I would set to rename_columns={} or so instead of the current state. Let me know if this makes sense :)
NinaWie
approved these changes
Jul 30, 2023
Member
NinaWie
left a comment
NinaWie
left a comment
There was a problem hiding this comment.
As said in the comments, I think the current version is fine :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #409
Split up kwargs into own variable.
Test already existed for this.