BUG: Read csv lists correctly#492
Merged
Merged
Conversation
fixes mie-lab#485 Used ast.literal_eval as eval is a bit dangerous
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 92.31% 92.32%
=======================================
Files 39 39
Lines 2004 2006 +2
Branches 340 340
=======================================
+ Hits 1850 1852 +2
Misses 133 133
Partials 21 21
☔ View full report in Codecov by Sentry. |
bifbof
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #485
Used
ast.literal_evalasevalis a bit dangerous.But I think we need to communicate that this is done for some reason, or that
tripsis a optional column.This relates to #491.