Skip to content

ENH: replace pygeos with calls to shapely 2.0#477

Merged
hongyeehh merged 2 commits into
mie-lab:masterfrom
bifbof:replace_pygeos
Jun 27, 2023
Merged

ENH: replace pygeos with calls to shapely 2.0#477
hongyeehh merged 2 commits into
mie-lab:masterfrom
bifbof:replace_pygeos

Conversation

@bifbof
Copy link
Copy Markdown
Collaborator

@bifbof bifbof commented Jun 27, 2023

With pygeos being integrated into shapely we don't need this dependency anymore.
Thus this PR removes all calls to pygeos.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (11ff487) 92.35% compared to head (502959c) 92.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   92.35%   92.35%   -0.01%     
==========================================
  Files          39       39              
  Lines        2015     2014       -1     
  Branches      344      344              
==========================================
- Hits         1861     1860       -1     
  Misses        133      133              
  Partials       21       21              
Impacted Files Coverage Δ
trackintel/geogr/distances.py 94.56% <100.00%> (ø)
trackintel/preprocessing/util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hongyeehh
Copy link
Copy Markdown
Member

Thanks for the fix. This is great; we shall push a new version soon and update the conda dependencies accordingly.

@hongyeehh hongyeehh merged commit c9b3b06 into mie-lab:master Jun 27, 2023
@bifbof bifbof deleted the replace_pygeos branch June 27, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants