Open
Conversation
Contributor
|
Thanks for this @mmenanno ! |
Member
|
Hello people 👋 I'd be ok with this and we already discussed this point several times in the past few years, but @tdreyno has the last call on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think preventing current dependancies versions solely because based on supporting EOL Ruby versions might be a code smell (#2877). Dropping support for the EOL versions of Ruby, and in turn relaxing the HAML versions restrictions again.
I updated the matrix for CI ruby versions but someone would need to change the repo settings to change which ones are set to "required"