Remove incorrect URL validation (fixes #85) - #86
Merged
Conversation
If enough deltalinks are called, this check will eventually fail as a case insensitive 'http' will appear in the string. We should be doing this check in the cstor.
Michael Mainer (MIchaelMainer)
requested review from
Darrel (darrelmiller) and
Muthurathinam (muthurathinam)
July 7, 2018 00:43
vikyding
approved these changes
Jul 25, 2018
Contributor
Author
|
For future, I ran this against the php-connect-sample by performing the following steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If enough deltalinks are called, this check will eventually fail as a case insensitive 'http' will appear in the string. We should be doing this check in the cstor.
Most of the tests passed. The ones that failed are expected.