Be able to change the accessToken of a request - #79
Merged
Caitlin Russell (caitlinrussell) merged 1 commit intoApr 30, 2018
Conversation
|
This is great! Thanks for adding access to the accessToken and cleaning up the formatting. It looks like there has been added security for the password grant flow; thanks for updating this as well. |
Caitlin Russell (caitlinrussell)
approved these changes
Apr 30, 2018
Caitlin Russell (caitlinrussell)
pushed a commit
that referenced
this pull request
Apr 30, 2018
Caitlin Russell (caitlinrussell)
pushed a commit
that referenced
this pull request
Apr 30, 2018
Reapply #79 without clientSecret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the method
setAccessToken()to theGraphRequest-class, as suggested in #68.I also added a functional unittest for it that passes. I did however have to adjust the method to fetch accessTokens.
Finally I replaced all tabs by spaces in those test-files.