Functional test bugfixes - #25
Merged
Merged
Conversation
added 2 commits
June 28, 2017 10:49
Administrative units is not currently available in Graph v1.0; therefore, there are no models to use with these tests
Caitlin Russell (caitlinrussell)
requested review from
Michael Mainer (MIchaelMainer) and
dan-silver
June 28, 2017 18:48
dan-silver
approved these changes
Jun 28, 2017
dan-silver
left a comment
dan-silver
left a comment
Contributor
There was a problem hiding this comment.
Can you explain in code comments why we're disabling the admin unit tests? I imagine that would look odd to a developer who didn't see this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: