Build tests - #19
Merged
Merged
Conversation
Caitlin Russell (caitlinrussell)
commented
May 24, 2017
Caitlin Russell (caitlinrussell)
commented
- Schema extensions
- OneNote
Caitlin Russell (caitlinrussell)
requested review from
Michael Mainer (MIchaelMainer) and
dan-silver
May 24, 2017 21:59
dan-silver
reviewed
May 25, 2017
|
|
||
| /** | ||
| * Gets the attendee | ||
| * The type of attendee - whether it's a person or a resource, and whether required or optional if it's a person. |
Contributor
There was a problem hiding this comment.
In the future, can we separate pull requests by generated code and hand written to make it easier to review?
| /** | ||
| * @group functional | ||
| */ | ||
| public function testSchemaExtensions() |
Contributor
There was a problem hiding this comment.
Not sure, but based on the file name is this in the right spot?
dan-silver
approved these changes
May 25, 2017
Michael Mainer (MIchaelMainer)
approved these changes
May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.