Skip to content

Update client options, middleware options and base client in tasks #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikithauc merged 2 commits into from
May 24, 2022
Merged

Update client options, middleware options and base client in tasks #808

nikithauc merged 2 commits into from
May 24, 2022

Conversation

@nikithauc
Copy link
Contributor

@nikithauc nikithauc commented May 24, 2022

  • AuthProvider in ClientOptions is set to be required
  • Removed customHosts options from ClientOptions. User will have be pass any custom hosts through the auth provider
  • Removed middleware options to use Kiota RequestOption
  • Updated PageIterator client to use GraphBaseClient

@nikithauc nikithauc requested review from baywet, rkodev and zengin May 24, 2022 08:22
@nikithauc nikithauc merged commit 729ae20 into 4.0.0 May 24, 2022
@baywet baywet deleted the nikithauc/tempTasks-optionsUpdates branch November 30, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zengin zengin Awaiting requested review from zengin

@rkodev rkodev Awaiting requested review from rkodev

1 more reviewer

@baywet baywet baywet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikithauc @baywet