Change GraphRequest.count default value to true #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
approved these changes
Oct 8, 2020
Contributor
Author
|
@baywet the CI fails and I don't have access to the details. |
Member
|
@OlivierCuyp I just re-ran the job that failed, I think it was a temporary blip. |
MIchaelMainer
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the default value of GraphRequest.count to true
Motivation
It is unnatural to have to specify myRequest.count(true).
Programmers should just do myRequest.count() to get a count.
I put this as a breaking change but I seriously doubt that anybody used
myRequest.count()expecting to have no count.myRequest.count(true)&myRequest.count(false)are still retro-compatible.Test plan
Current test still pass
Closing issues
Fixes #241
Types of changes
Checklist