Version 2.0.0 #179

muthurathinam · 2019-05-29T08:58:56Z

New Features (Breaking Changes)

We are excited to announce that we will be releasing the preview for version 2.0.0 which will have the following changes

Polyfilling

Removed polyfills for Fetch and Promise, Now its the responsibility of the library users to polyfill these based on their environment support needs.

New minified files

graph-js-sdk-web.js and graph-js-sdk-core.js files are no longer available, new file named graph-js-sdk.js will be shipped along with graph-es-sdk.js. Both graph-js-sdk.js and graph-es-sdk.js will not depend on the isomorphic-fetch and es6-promise anymore.

Getting Raw Response

When making request using callback method raw response will not be passed as the param to the callback, instead one can get the same by using .responseType(ResponseType.RAW).

Renaming MSALAuthenticationProvider

Authentication provider and its options for MSAL library are now renamed from MSALAuthenticationProvider to ImplicitMSALAuthenticationProvider.

Initializing ImplicitMSALAuthenticationProvider

In order to create an instance of ImplicitMSALAuthenticationProvider previously named as MSALAuthenticaitonProvider. Now you can only pass an instance of MSAL's UserAgentApplication and MSALAuthenticationProviderOptions

Creating MSAL's UserAgentApplication

MSAL changed its way of initializing UserAgentApplication (also called as MSALInstance) in v1.0.0. Since we updated our MSAL's dependency to latest stable version and ImplicitMSALAuthenticationProvider modified to adapt the same. Creating instance of ImplicitMSALAuthenticationProvider takes UserAgentApplication created as per MSAL v1.0.0

Test plan

npm run test to test newly added tests.
Fire up the browser sample to test the new initialization method

Closing issues

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

* Removed polyfill dependencies for fetch and promise * Removed Browserify and replaced it with rollup

@nextlink

* Modified params passed in for initializaiton of MSAL provider - Breaking change * Fixed @nextlink property in Batching * Added negative value check for default values in retry and redirect handlers * Fixed - Auth handler replaces the authorization header * Fixed - Telemetry handler replaces the sdkVersion header

…es by msal)

* #169 * #158 * #151

…ons to ImplicitMSALAuthenticationProvider and ImplicitMSALAuthenticationProviderOptions

…k-javascript into v2.0.0

…ionProviderOptions

…k-javascript into v2.0.0

README.md

docs/CreatingClientInstance.md

samples/browser/src/index.html

spec/package.json

src/Constants.ts

…in node v6

mlynam · 2019-06-18T14:03:13Z

Any ETA on the changes in this review? We're in an awkward place with this lib until this merges because of the old MSAL reference.

bitflower · 2019-06-18T21:04:26Z

Absolutely agree, spent some hours debugging mismatches today.

Is there a dev release on npm to help test?

muthurathinam · 2019-06-19T04:43:14Z

@bitflower we haven't released in npm yet. will let you know once preview is released.

NoPhaseNoKill · 2019-06-19T05:31:26Z

Having the exact same issue as @bitflower as noted in this: #193 and am really needing this fix to be published. Do we have an ETA?

src/ImplicitMSALAuthenticationProvider.ts

muthurathinam · 2019-06-19T06:23:23Z

@bitflower @mlynam @NoPhaseNoKill we have planned a preview release for v2.0.0 today. will update you once its released.

NoPhaseNoKill · 2019-06-19T06:26:36Z

Thanks for the help guys. Appreciate the release when it does go out :)

bitflower · 2019-06-19T06:59:33Z

That's great to hear, thanks!

src/ImplicitMSALAuthenticationProvider.ts

src/browser/ImplicitMSALAuthenticationProvider.ts

muthurathinam · 2019-06-19T10:00:53Z

@bitflower @mlynam @NoPhaseNoKill
Preview for 2.0.0 is released, try it out and let me know your feedback.
To install the preview version of the library, use npm install @microsoft/microsoft-graph-client@Preview.

Refer this release notes for the list of changes.

bitflower · 2019-06-19T12:25:11Z

Worked for my simple use case!

Having a little trouble with my typescript imports though. Only got it to work like this:

import { AuthenticationProvider } from '@microsoft/microsoft-graph-client';
import * as MSALAuthenticationProvider from '@microsoft/microsoft-graph-client/lib/es/browser/ImplicitMSALAuthenticationProvider';

export let authProvider: AuthenticationProvider;

export const getAuthProvider = (userAgentApplication, scopes) => {
  console.log('getAuthProvider');
  authProvider = new MSALAuthenticationProvider.ImplicitMSALAuthenticationProvider(
    userAgentApplication,
    {
      scopes
    }
  );
};

Repo: https://github.com/bitflower/stencil-ms-graph
Code: https://github.com/bitflower/stencil-ms-graph/blob/master/src/graph/auth-provider.ts

mlynam · 2019-06-19T15:21:51Z

@bitflower I used the following import import { ImplicitMSALAuthenticationProvider } from '@microsoft/microsoft-graph-client/lib/src/ImplicitMSALAuthenticationProvider';

This is the method they suggest in the docs as well.

mlynam · 2019-06-19T15:32:20Z

@muthurathinam this is working for me now. I've only attempted to access the /me api so far, however.

bitflower · 2019-06-19T16:41:08Z

Thanks @mlynam your imports worked!

NoPhaseNoKill · 2019-06-19T21:21:18Z

This has resolved the scopes issue for me. Thanks guys, will let you know if any other issues!

muthurathinam · 2019-06-20T03:02:18Z

Worked for my simple use case!

Having a little trouble with my typescript imports though. Only got it to work like this:
import { AuthenticationProvider } from '@microsoft/microsoft-graph-client';
import * as MSALAuthenticationProvider from '@microsoft/microsoft-graph-client/lib/es/browser/ImplicitMSALAuthenticationProvider';

export let authProvider: AuthenticationProvider;

export const getAuthProvider = (userAgentApplication, scopes) => {
  console.log('getAuthProvider');
  authProvider = new MSALAuthenticationProvider.ImplicitMSALAuthenticationProvider(
    userAgentApplication,
    {
      scopes
    }
  );
};
Repo: https://github.com/bitflower/stencil-ms-graph
Code: https://github.com/bitflower/stencil-ms-graph/blob/master/src/graph/auth-provider.ts

Yes @bitflower this is the feasible way as of now.

muthurathinam-m and others added 20 commits May 7, 2019 11:38

Changes:

d274967

* Removed polyfill dependencies for fetch and promise * Removed Browserify and replaced it with rollup

Updated readme with installation guide

454c0a3

Added tests for middleware util append request header method

da2c5e3

Upgraded to msal 1.0.0 and made corresponding changes (breaking chang…

ee554ad

…es by msal)

fix readme typo

edd80e4

Merge remote-tracking branch 'origin/dev' into v2.0.0

fe087b7

Bug Fixes:

10217b1

* #169 * #158 * #151

Merge remote-tracking branch 'origin/dev' into v2.0.0

ad564db

Renamed MSALAuthenticationProvider and MSALAuthenticationProviderOpti…

47093b1

…ons to ImplicitMSALAuthenticationProvider and ImplicitMSALAuthenticationProviderOptions

Update README.md

7cbe481

Update README.md

10df55f

Removing unnecessary dependencies

c2cb47a

Merge branch 'v2.0.0' of https://github.com/microsoftgraph/msgraph-sd…

418c2a2

…k-javascript into v2.0.0

Update README.md

b3a2713

Update README.md

1f860b1

Update README.md

930a96c

Renaming ImplicitMSALAuthenticationProviderOptions to MSALAuthenticat…

fe07204

…ionProviderOptions

Merge branch 'v2.0.0' of https://github.com/microsoftgraph/msgraph-sd…

159e1c4

…k-javascript into v2.0.0

Added babel polyfill in readme

e90f4f8

muthurathinam requested review from MIchaelMainer, NakulSabharwal and darrelmiller May 29, 2019 08:58

Bump version with 2.0.0-Preview.1

5803f2c

MIchaelMainer requested changes May 29, 2019

View reviewed changes

muthurathinam-m added 5 commits May 30, 2019 10:19

Auto generation of version file and fix review comments

441cfa0

2.0.0-Preview.0

9714304

Picking correct preview version

01d698c

Precommit hook will now add generated Version.ts file to commit

e7c7f01

Fix CI build error in gulpfile.js: async funcitons are not supported …

0d30e21

…in node v6

Merge branch 'dev' into v2.0.0

700e2be

muthurathinam requested a review from MIchaelMainer June 13, 2019 03:30

darrelmiller mentioned this pull request Jun 18, 2019

ClientConfigurationError: Scopes are required to obtain an access token #193

Closed

4 tasks

Merge branch 'dev' into v2.0.0

93680f8

darrelmiller reviewed Jun 19, 2019

View reviewed changes

src/ImplicitMSALAuthenticationProvider.ts Outdated Show resolved Hide resolved

darrelmiller previously approved these changes Jun 19, 2019

View reviewed changes

Renamed msalInstance as msalApplication

032f559

muthurathinam dismissed darrelmiller’s stale review via 032f559 June 19, 2019 06:31

NakulSabharwal reviewed Jun 19, 2019

View reviewed changes

src/ImplicitMSALAuthenticationProvider.ts Show resolved Hide resolved

NakulSabharwal reviewed Jun 19, 2019

View reviewed changes

src/browser/ImplicitMSALAuthenticationProvider.ts Show resolved Hide resolved

NakulSabharwal self-requested a review June 19, 2019 08:57

NakulSabharwal approved these changes Jun 19, 2019

View reviewed changes

muthurathinam merged commit f813590 into dev Jun 19, 2019

muthurathinam deleted the v2.0.0 branch June 19, 2019 09:18

Version 2.0.0 #179

Version 2.0.0 #179

Uh oh!

Conversation

muthurathinam commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Features (Breaking Changes)

Polyfilling

New minified files

Getting Raw Response

Renaming MSALAuthenticationProvider

Initializing ImplicitMSALAuthenticationProvider

Creating MSAL's UserAgentApplication

Test plan

Closing issues

Types of changes

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mlynam commented Jun 18, 2019

Uh oh!

bitflower commented Jun 18, 2019

Uh oh!

muthurathinam commented Jun 19, 2019

Uh oh!

NoPhaseNoKill commented Jun 19, 2019

Uh oh!

Uh oh!

muthurathinam commented Jun 19, 2019

Uh oh!

NoPhaseNoKill commented Jun 19, 2019

Uh oh!

bitflower commented Jun 19, 2019

Uh oh!

Uh oh!

Uh oh!

muthurathinam commented Jun 19, 2019

Uh oh!

bitflower commented Jun 19, 2019

Uh oh!

mlynam commented Jun 19, 2019

Uh oh!

mlynam commented Jun 19, 2019

Uh oh!

bitflower commented Jun 19, 2019

Uh oh!

NoPhaseNoKill commented Jun 19, 2019

Uh oh!

muthurathinam commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

muthurathinam commented May 29, 2019 •

edited

Loading