Skip to content

Remove runtime code generation and execution #246

@guybarnard

Description

@guybarnard

Bug Report
Prerequisites

[ Y] Can you reproduce the problem?
[Y ] Are you running the latest version?
[ Y] Are you reporting to the correct repository?
[ Y] Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.
Description
The isNodeEnvironment test performs runtime code generation and execution. This is not allowed in certain runtime environments and may be unnecessary for a lightweight API wrapper. An example of an environments that do not allow code generation are third party cloud serverless function execution environments.
Steps to Reproduce
See https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/dev/src/HTTPClientFactory.ts#L29
Additional Context
Please remove the new Function and replace with a different check that works in browsers, webworkers, service workers, and node environment.
Usage Information
SDK Version -2.0.0
Browser Name - Cloudflare Serviceworker

Version - V8 Engine, version not available
AB#6003

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions