Generated v1.0 models and request builders using Typewriter#708
Merged
Conversation
github-actions
bot
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc and
zengin
as code owners
baywet
approved these changes
Mar 23, 2021
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
LGTM. Here we have the changes for two weeks as last week I didn't pick the changes because of the major release. There's what looks like a breaking change which is in facts an insertion in the class inheritance tree and it should provide the same fluent API experience for consumers.
pkgdiff_reports.zip
Member
|
(the inheritance change I'm talking about microsoftgraph/msgraph-metadata@09ef107#diff-d0f38f480df4fa82f10ae7d5ff583893072be58fac64e75000f9150aff9c503bR8525) |
MIchaelMainer
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is fd5ca9b.
Important Check for unexpected deletions or changes in this PR.