Skip to content

bugfix/ref serailization#576

Merged
baywet merged 12 commits intofeature/v3from
bugfix/ref-serailization
Dec 7, 2020
Merged

bugfix/ref serailization#576
baywet merged 12 commits intofeature/v3from
bugfix/ref-serailization

Conversation

@baywet
Copy link
Copy Markdown
Member

@baywet baywet commented Nov 27, 2020

fixes #575

  • codegen update
  • adds a unit test for manager update

@baywet baywet self-assigned this Nov 27, 2020
@baywet baywet added this to the 2.4.2 milestone Nov 27, 2020
@baywet

This comment has been minimized.

Sign in to view
This was referenced Nov 27, 2020
Merged
Closed
@baywet

This comment has been minimized.

Sign in to view
@baywet

This comment has been minimized.

Sign in to view
@baywet baywet marked this pull request as draft November 30, 2020 15:36
@baywet baywet marked this pull request as ready for review December 1, 2020 19:43
@baywet
Copy link
Copy Markdown
Member Author

baywet commented Dec 1, 2020

@zengin @MIchaelMainer this is ready for review

zengin
zengin previously approved these changes Dec 1, 2020
View reviewed changes
@baywet baywet marked this pull request as draft December 2, 2020 18:16
@baywet baywet force-pushed the bugfix/ref-serailization branch from a12073b to e4556b3 Compare December 2, 2020 19:00
@baywet baywet changed the base branch from dev to feature/v3 December 2, 2020 19:00
@baywet baywet modified the milestones: 2.4.2, 3.0.0 Dec 2, 2020
@baywet baywet marked this pull request as ready for review December 2, 2020 19:02
@baywet baywet mentioned this pull request Dec 2, 2020
Closed
@baywet baywet linked an issue Dec 2, 2020 that may be closed by this pull request
OData cast implementation needs to be reviewed to avoid generating too much code #562
Closed
@github-actions

This comment has been minimized.

Sign in to view
@baywet baywet requested a review from zengin December 4, 2020 13:44
zengin
zengin approved these changes Dec 4, 2020
View reviewed changes
src/test/java/com/microsoft/graph/functional/UserTests.java
assertNotNull(page);
}
@Test
public void setMyBoss() {
Copy link
Copy Markdown
Contributor

@zengin zengin Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@baywet baywet merged commit 407d514 into feature/v3 Dec 7, 2020
@baywet baywet deleted the bugfix/ref-serailization branch December 7, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@nikithauc nikithauc Awaiting requested review from nikithauc

1 more reviewer

@zengin zengin zengin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

conflicting

Projects

None yet

Milestone

3.0.0-preview

Development

Successfully merging this pull request may close these issues.

Assign manager OData cast implementation needs to be reviewed to avoid generating too much code

2 participants

@baywet @zengin