Generated v1.0 models and request builders using Typewriter#561
Conversation
github-actions
bot
requested review from
baywet,
ddyett,
nikithauc,
peombwa and
zengin
| public void post(final AppRoleAssignment newAppRoleAssignment, final ICallback<? super AppRoleAssignment> callback) { | ||
| final String requestUrl = getBaseRequest().getRequestUrl().toString(); | ||
| final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/me/ownersAsAppRoleAssignment/" + newAppRoleAssignment.id); | ||
| final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/me/registeredUsersAsAppRoleAssignment/" + newAppRoleAssignment.id); |
There was a problem hiding this comment.
@zengin @MIchaelMainer I'm not sure where this is coming from, none of those endpoints seem to exist, unless some private preview kind of leaked in the public metadata?
There was a problem hiding this comment.
This looks like influence from the cast/filter functionality. Neither of these URLs are correct. This requires an investigation.
src/main/java/com/microsoft/graph/models/extensions/IBaseGraphServiceClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/graph/requests/extensions/BaseGraphServiceClient.java
Outdated
Show resolved
Hide resolved
| public void post(final AppRoleAssignment newAppRoleAssignment, final ICallback<? super AppRoleAssignment> callback) { | ||
| final String requestUrl = getBaseRequest().getRequestUrl().toString(); | ||
| final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/me/ownersAsAppRoleAssignment/" + newAppRoleAssignment.id); | ||
| final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/me/registeredUsersAsAppRoleAssignment/" + newAppRoleAssignment.id); |
There was a problem hiding this comment.
This looks like influence from the cast/filter functionality. Neither of these URLs are correct. This requires an investigation.
| import com.microsoft.graph.core.ClientException; | ||
| import com.microsoft.graph.concurrency.ICallback; | ||
| import com.microsoft.graph.models.extensions.ServicePrincipal; | ||
| import com.microsoft.graph.models.extensions.Device; |
There was a problem hiding this comment.
These ServicePrincipal to Device and Group change doesn't make sense. Actually, neither one of the models makes sense here.
update This looks like a change to match interfaces.
There was a problem hiding this comment.
I noticed that my change from a few months ago from star imports to selective imports sometimes over imports.
But that's not a big problem on it's own.
baywet
force-pushed
the
v1.0/pipelinebuild/4090728
branch
from
9c275ed to
0816203
Compare
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
The issues in the PR were already present and don't represent breaking new changes. We have a tracking item for the URL segments.
3 participants
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is b216a8b.
Important Check for unexpected deletions or changes in this PR.
update version in gradle.properties and Constants.java.
update version in readme.md
create tag and release
cc: @darrelmiller