Merged
Conversation
added 4 commits
August 20, 2018 11:17
NakulSabharwal
requested review from
darrelmiller,
davidmoten and
deepak2016
deepak2016
approved these changes
Sep 5, 2018
dadheech115
approved these changes
Sep 6, 2018
Contributor
|
@NakulSabharwal By the way, your problems with the last PR were because you need to do this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Changes proposed in this pull request
-Changed T2 to BodyType so that naming doesn't have conflict with class level T2
-Edited comment with BodyType
Explanation for change
-In some scenarios Action use different body than collection item, by which post of BaseCollectionRequest gets different parameter other than T2 and different body.
Links
Previous PR - #116