Skip to content

Fixes raw type iterator warning#115

Merged
NakulSabharwal merged 1 commit intodevfrom
rawtype-iterator-fix
Aug 20, 2018
Merged

Fixes raw type iterator warning#115
NakulSabharwal merged 1 commit intodevfrom
rawtype-iterator-fix

Conversation

@NakulSabharwal
Copy link
Copy Markdown
Contributor

@NakulSabharwal NakulSabharwal commented Aug 20, 2018

Fixes #37 iterator part.
Fix - Using wildcard <?> with iterator.

Changes proposed in this pull request
Removes raw type iterator and changing it to parameterized type as it is possible that future versions of java disallow the use of raw types.

@davidmoten
Copy link
Copy Markdown
Contributor

Nit: removing -> removes, changing -> changes, in commit: 'fix' instead of 'fixed' (mentioned #111).

Copy link
Copy Markdown
Contributor

@davidmoten davidmoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tis fine, we might need to revisit this class to improve type safety later though. Returning an EnumSet<?> from a method that is supplied a type is a bit odd.

@NakulSabharwal NakulSabharwal merged commit 2c8efc3 into dev Aug 20, 2018
@NakulSabharwal NakulSabharwal deleted the rawtype-iterator-fix branch August 20, 2018 06:16
@baywet baywet mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants