get HTTP status response code in GraphServiceException#111
Merged
deepak2016 merged 1 commit intodevfrom Aug 7, 2018
Merged
Conversation
deepak2016
requested review from
MIchaelMainer,
NakulSabharwal,
bullsseye and
davidmoten
NakulSabharwal
approved these changes
Aug 6, 2018
MIchaelMainer
approved these changes
Aug 6, 2018
davidmoten
approved these changes
Aug 6, 2018
Contributor
|
@deepak2016 instead of overflowing the title just shorten it. That way when people search PRs they can see what it's about without clicking in to it. In this case: "get HTTP status response code in GraphServiceException". By the way in terms of verb tenses the standard in PR titles is to imagine you are giving a command to the codebase (so you wouldn't start with "Exposing" but rather "Expose"). One other thing that you don't seem to be aware of is that you can edit your original comment (to fix the link to #107). Note that the verb tense thing is discussed in the Git documentation here and the tense is called the present imperative. |
Contributor
|
Fixed my explanation of the verb tense. |
deepak2016
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # #107
GraphServiceException encapsulates a bit too much?