Skip to content

BaseRequest typing #120

@davidmoten

Description

@davidmoten

Similar to discussion in #116, BaseRequest is not modelled optimally either. The obvious indicator is the very free typing of the send methods:

protected <T1, T2> T1 send(final HttpMethod method,
                               final T2 serializedObject) throws ClientException;

protected <T1, T2> void send(final HttpMethod method,
                                 final ICallback<T1> callback,
                                 final T2 serializedObject) 

T1 and T2 should not be there, BaseRequest should

@darrelmiller Typing-wise the codebase is a mess but I don't think this is that big a job to fix. You sort this out for one use case and code generation propagates it everywhere.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions