Create ManifestSpecv1.0.md by denelon · Pull Request #816 · microsoft/winget-cli

denelon · 2021-03-22T16:57:51Z

Manifest Schema v1.0

Microsoft Reviewers: Open in CodeFlow

Manifest Schema v1.0

github-actions · 2021-03-22T16:59:14Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

jsoref · 2021-03-22T17:08:46Z

doc/ManifestSpecv1.0.md

+PackageVersion: "1.6.10571.0"
+PackageLocale: "fr-FR"
+Publisher: "Microsoft"
+ShortDescription: "Le nouveau terminal Windows, une expérience de ligne de commande à onglets pour Windows."


Easiest way to ignore this is to add something like:

^ShortDescription: "Le nouveau.*"$

to patterns.txt (preferably w/ a comment referencing this line).

Adjustments to language to provide greater clarity.

github-actions · 2021-03-22T18:05:14Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-03-22T18:06:37Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

jedieaston · 2021-03-22T18:10:54Z

doc/ManifestSpecv1.0.md

+ - Architecture: "x64"
+   InstallerUrl: "https://github.com/microsoft/terminal/releases/download/v1.6.10571.0/Microsoft.WindowsTerminal_1.6.10571.0_8wekyb3d8bbwe.msixbundle"
+   InstallerSha256: 092aa89b1881e058d31b1a8d88f31bb298b5810afbba25c5cb341cfa4904d843
+   SignatureSha256: e53f48473621390c8243ada6345826af7c713cf1f4bbbf0d030599d1e4c175ee


Is InstallerType no longer required?

Great catch! I've been working on this one so much I missed it.

Installer Type

github-actions · 2021-03-22T18:19:33Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-03-22T18:22:06Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-03-22T18:24:03Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-03-22T18:24:07Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-03-22T18:31:18Z

Misspellings found, please review:

commande
onglets
rience
une
WSL

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"commande onglets rience une WSL "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

quangkieu · 2021-03-23T15:00:49Z

I wonder if we could have field for windows shim like wt.exe of windows terminal, or wsl.exe, unbuntu.exe of wsl distro?

jedieaston · 2021-03-23T15:19:32Z

I wonder if we could have field for windows shim like wt.exe of windows terminal, or wsl.exe, unbuntu.exe of wsl distro?

That should be going in the command field, I think.

denelon · 2021-03-23T15:39:10Z

@quangkieu, yes the "commands" key is intended to identify the command one would execute to run the program/package. It's currently just an informational field, but that is the intent.

quangkieu · 2021-03-23T15:46:22Z

I wonder how about winget generate one, for example the unpacked zip install, or git.exe so we only need folder windowsapp for those shim but the app could install, unpack in correct folder. We also have a flag if user want to disable the generated shim?

denelon · 2021-03-23T15:54:48Z

Our plan for supporting .zip and standalone .exe as a package is a bit different. We're looking at having a path where they will be placed on a drive, and an entry in the PATH environment variable. We will also add an entry in Add/Remove Programs so they can be removed and upgraded as other packages are. This Add/Remove Programs integration would require a more recent version of Windows, but the package manager would still be able to handle the scenarios for uninstall and upgrade.

quangkieu · 2021-03-23T16:27:38Z

My only concern is the amount of entries on PATH variable. And if other microsoft team, product already has shim feature, I would want to suggest to improve and promote it to be official solution instead just patch work in those products only

KevinLaMS

Looks great.

Create ManifestSpecv1.0.md

4d2dc89

Manifest Schema v1.0

jsoref reviewed Mar 22, 2021

View reviewed changes

Update ManifestSpecv1.0.md

8e53645

Adjustments to language to provide greater clarity.

Update ManifestSpecv1.0.md

7414509

jedieaston reviewed Mar 22, 2021

View reviewed changes

Update ManifestSpecv1.0.md

9eefbd5

Installer Type

Update ManifestSpecv1.0.md

cfd188a

Update ManifestSpecv1.0.md

79865e7

Update ManifestSpecv1.0.md

9176948

denelon mentioned this pull request Mar 22, 2021

PSA: New Manifest Schema microsoft/winget-pkgs#8900

Closed

denelon marked this pull request as ready for review March 30, 2021 16:51

denelon requested a review from a team as a code owner March 30, 2021 16:51

KevinLaMS approved these changes Mar 31, 2021

View reviewed changes

denelon merged commit ee7dd86 into microsoft:master Mar 31, 2021

jsoref mentioned this pull request Mar 31, 2021

Spelling #837

Merged

Conversation

denelon commented Mar 22, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

jsoref Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

jedieaston Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

denelon Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

github-actions bot commented Mar 22, 2021

Misspellings found, please review:

Uh oh!

quangkieu commented Mar 23, 2021

Uh oh!

jedieaston commented Mar 23, 2021

Uh oh!

denelon commented Mar 23, 2021

Uh oh!

quangkieu commented Mar 23, 2021

Uh oh!

denelon commented Mar 23, 2021

Uh oh!

quangkieu commented Mar 23, 2021

Uh oh!

KevinLaMS left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

denelon commented Mar 22, 2021 •

edited by ghost

Loading