Add setting for installer log file names#5802
Draft
Trenly wants to merge 4 commits intomicrosoft:masterfrom
Draft
Add setting for installer log file names#5802Trenly wants to merge 4 commits intomicrosoft:masterfrom
Trenly wants to merge 4 commits intomicrosoft:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
e3e4014 to
81d76e6
Compare
Contributor
Author
|
Marking as draft to fix merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the Manifest name is just too long. While I would love to be able to give users the ability to control the format directly using token replacement and all sorts of other cool stuff, that's a bit much for right now.
To help alleviate the issue, I've added a setting that controls how installer file names are generated. With this change, instead of being forced into the Package ID and version with timestamp, it is now possible to have the default installer log name be shorter. While this doesn't actually resolve the issue, it does make it possible to at least mitigate
Note that this only affects the installer log name, not the WinGet log name, and only for installers which support passing of the log name. This PR does not affect the behavior of
--log <location>Microsoft Reviewers: Open in CodeFlow