Skip to content

Update resource file app(s) -> application(s)#283

Closed
thlac wants to merge 1 commit intomicrosoft:masterfrom
thlac:language_patch1
Closed

Update resource file app(s) -> application(s)#283
thlac wants to merge 1 commit intomicrosoft:masterfrom
thlac:language_patch1

Conversation

@thlac
Copy link

@thlac thlac commented May 22, 2020 •
edited
Loading

A pull request about the language use we talked about in #240

I have some notes about the changes, we can discuss:

  1. I am not sure if we should use the word "app" or "application", there are already requests in the pipeline to support stuff like fonts, my opinion is that it should be packages.
  2. The above not withstanding, I think it should be "application" over "app", my two main reasons being that "application" translates better to other languages, and "app" I think infers something I would get from the Store exclusively.
  3. I've stayed true to the original text, but I think SourceArgumentDescription should probably be "applications", the source of your repository can still result in multiple results. (I think ExactArgumentDescription should stay singular as that parameter will result in one exact result), but maybe both of them shouldn't talk about applications at all, but results, which would be in line with the rest of parameters.

If we change consensus, I can update the pull request accordingly.

Microsoft Reviewers: Open in CodeFlow

@thlac thlac requested a review from a team as a code owner May 22, 2020 05:56
@JohnMcPMS
Copy link
Member

JohnMcPMS commented May 22, 2020

@denelon , @KevinLaMS

I had originally used application (as is quite evident in the type names throughout) as the generic term for what we are managing. Should we switch the documentation to use the term package? I can guess your responses, but this way you will be on record 😄

@denelon
Copy link
Collaborator

denelon commented May 26, 2020

I have had plenty of discussion with others on the topic of "package" vs. "App" vs. "Application" etc.

I would lean in the direction of the generic "package" as the largest set of things the client can install.

@JohnMcPMS JohnMcPMS mentioned this pull request Jul 11, 2020
Merged
@PRIMETSS
Copy link

PRIMETSS commented Jul 11, 2020

Yes, agree, 'Package' is so more generic and a bit more future proof. It;s a 'Package Manager', 'Packages of items' should be what it handles. The term App or even Application muddies the waters

@JohnMcPMS
Copy link
Member

JohnMcPMS commented Jul 31, 2020

The change to use the term packages everywhere was released as part of https://github.com/microsoft/winget-cli/releases/tag/v0.1.42101-preview

Closing out this PR, thanks for the feedback.

@JohnMcPMS JohnMcPMS closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thlac @JohnMcPMS @denelon @PRIMETSS