Switch to using sqlite3_prepare_v2#134
Merged
JohnMcPMS merged 1 commit intomicrosoft:masterfrom May 13, 2020
JohnMcPMS:prepv2
Merged
Switch to using sqlite3_prepare_v2#134JohnMcPMS merged 1 commit intomicrosoft:masterfrom JohnMcPMS:prepv2
JohnMcPMS merged 1 commit intomicrosoft:masterfrom
JohnMcPMS:prepv2
Conversation
ranm-msft
reviewed
May 13, 2020
| Statement StatementBuilder::Prepare(Connection& connection, bool persistent) | ||
| Statement StatementBuilder::Prepare(Connection& connection) | ||
| { | ||
| Statement result = Statement::Create(connection, m_stream.str(), persistent); |
Contributor
There was a problem hiding this comment.
can we instead do if > 16299
i suspect most machines will be > 16299
ranm-msft
approved these changes
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
v3 is not available on Windows 10 (16299), and we don't really need or use the persistent statements in a meaningful way. Fall back to v2 and remove the persistent statement support.
Validation
Regression tests and manual use against production environment.