Repository navigation
Enable pythonenvs-scoped PEP 723 rollout - #1978
Stella Huang (StellaHuang95) merged 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the dedicated experiment rollout for PEP 723 inline-script environments.
No open issues 🎉
What changed in this PR
Enables a dedicated experiment rollout for PEP 723 inline-script environments while retaining the default-off setting and explicit user/workspace overrides.
Changes:
- Maps the setting to the
/pythonenvs/config.python-envs.inlineScripts.enabledstartup treatment. - Runs smoke tests in separate explicit-off and explicit-on VS Code hosts.
- Adds assertions for experiment metadata and enabled inline-script command registration.
| File | Description |
|---|---|
src/test/smoke/registration.smoke.test.ts |
Verifies the scoped experiment metadata and absence of onExP. |
src/test/smoke/inlineScriptsEnabled.smoke.test.ts |
Checks that an explicit user opt-in registers inline-script commands. |
package.json |
Configures the treatment and includes both smoke-test hosts. |
.vscode-test.mjs |
Seeds separate user settings and defines the enabled smoke-test host. |
Review effort: Balanced
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "954884b16f490ea8134aa73ff535b2ea617655a86f7c5c453e17a020ca018d69": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Bill Schnurr (bschnurr)
left a comment
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Bill Schnurr (bschnurr)
added
the
review-auto:approved
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Map the inline-script setting to the dedicated ExP namespace and cover explicit opt-in and opt-out behavior in real VS Code smoke hosts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
e589eb7 to
a4c9605
Compare
|
Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "ab76cda2b44d66f00ffd056e9469b530ab5cafe7be45de4943d79972ddc9670a": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Summary
python-envs.inlineScripts.enabledto the dedicated/pythonenvs/config.python-envs.inlineScripts.enabledtreatmentValidation
npm run lintnpm run compile-testsnpm run compilenpm run smoke-test -- --fail-zero— 31 passing in the default-off host and 1 passing in the explicit-on hostThe commit is SSH-signed and rebased onto the current
main, including the global-selection routing fix from #1979.Relates to #1602