Repository navigation
Make python-envs.terminal.autoActivationType syncable via Settings Sync - #1937
Mohit Yadav (mohityadav8) wants to merge 5 commits into
Conversation
Change scope from machine to window so the setting syncs and applies to new remotes and dev containers. A remote's own settings still override it. Fixes microsoft#1640
3143bd2 to
4d0adf0
Compare
Eduardo Villalpando Mello (edvilme)
added
the
bug
Eduardo Villalpando Mello (edvilme)
left a comment
Eduardo Villalpando Mello (edvilme)
left a comment
There was a problem hiding this comment.
lgtm, thanks for your contribution
There was a problem hiding this comment.
🟡 Changes recommended
The activation resolver ignores the workspace values newly permitted by this scope change.
1 open issue
What changed in this PR
This PR makes the terminal auto-activation preference eligible for Settings Sync, aiming to carry users’ preferences to new remotes and dev containers and address #1640.
Changes:
- Changes
python-envs.terminal.autoActivationTypefrommachinescope towindow, also allowing workspace-level configuration.
| File | Description |
|---|---|
package.json |
Changes the terminal auto-activation setting’s scope to window. |
Review effort: Balanced
Eduardo Villalpando Mello (edvilme)
left a comment
Eduardo Villalpando Mello (edvilme)
left a comment
There was a problem hiding this comment.
Reviewer is correct, we should check the workspace value as higher priority before the global values, and we should have a test
|
Fixed the setter in 43d48ee: setAutoActivationType() now writes to the existing workspaceFolder/workspace override when one is present, falling back to global otherwise. Added regression tests covering all four scopes. Eduardo Villalpando Mello (@edvilme) could you approve the pending workflow runs and take another look? |
|
ci is green |
Change scope from machine to window so the setting syncs and applies to new remotes and dev containers. A remote's own settings still override it. Fixes #1640