test: cover registered package manager lifecycles by edvilme · Pull Request #1704 · microsoft/vscode-python-environments

Eduardo Villalpando Mello (edvilme) · 2026-08-07T23:17:17Z

Summary

Adds a package-manager-centric integration baseline that intentionally precedes and de-risks #1686, so the package-manager command refactor is exercised against behavior established on main.

drives one stateful install/list/direct-package/uninstall lifecycle per active profile
uses unique disposable projects and manager-owned disposable environments
exercises the live registered manager instances through a runtime-gated integration-test bridge
guards registry completeness so every registered package-manager ID has an active fixture or explicit deferral
covers normal Pip execution and Conda when their runtime prerequisites are available
records an uncached baseline instead of assuming a newly created environment is empty
restores workspace-scoped configuration from inspect() snapshots and performs guarded failure-safe cleanup
defers Poetry pending a Poetry-owned project/lockfile lifecycle
defers uv-backed Pip because changing the machine-scoped selection reliably within one extension host was not stable on main, while available-version lookup would also introduce uv tool run pip network seeding
pins the disposable integration-test user profile to normal Pip execution

Validation

npm run compile
npm run compile-tests
npm run lint
npm run unittest
targeted packageManagement.integration.test.js: 3 passing, 2 prerequisite skips locally
- Pip skipped because quick create selected Python 3.15.0 alpha, whose bundled Pip metadata is incomplete
- Conda skipped because Conda is not installed
reviewer specialist: clean, no Critical or Important findings

The active Pip and Conda fixtures require package-index/network access when their runtime prerequisites are present.

Fixes #1701

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

Copilot

Pull request overview

Adds a package-manager-centric integration baseline to exercise install/list/direct-deps/uninstall lifecycles against the live registered package manager instances, establishing behavioral coverage ahead of the package-manager command refactor work.

Changes:

Adds a fixture registry describing active/deferred package managers and their expected capabilities.
Reworks the integration test to drive a disposable project + disposable environment lifecycle per active profile, with registry completeness guards and prerequisite-based skips.
Adds an integration-test-only API bridge (env-gated) to expose the live registered PackageManager implementations, and pins the integration test user profile to normal pip execution (python-envs.alwaysUseUv=false).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/test/integration/packageManagerFixtures.ts	Introduces fixture definitions for registered package managers, capabilities, and per-manager profiles (active vs deferred).
src/test/integration/packageManagement.integration.test.ts	Implements the fixture-driven integration lifecycle tests and registry completeness checks, plus robust cleanup and prerequisite skips.
src/internal.api.ts	Adds a `registeredManager` getter on `InternalPackageManager` to expose the wrapped live implementation for tests.
src/extension.ts	Env-gated integration-test bridge that exposes registered package managers via the exported API object.
.vscode-test.mjs	Seeds integration test user settings to force `python-envs.alwaysUseUv=false` for consistent pip execution during integration runs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/test/integration/packageManagement.integration.test.ts:150

addPythonProject is a synchronous (void-returning) API, so await here is redundant and can confuse readers (and may be flagged by @typescript-eslint/await-thenable if enabled).

        await api.addPythonProject(project);

This reverts commit 596583f.

This reverts commit 0fa9ad6.

Package manager coverage is being developed separately in PR #1704. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

…ration-coverage # Conflicts: # api/CHANGELOG.md # api/package-lock.json # api/package.json # src/features/pythonApi.ts

Stella Huang (StellaHuang95) · 2026-08-14T21:56:44Z

🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:42Z

+        environmentManagerId: CONDA_MANAGER_ID,
+        name: 'Conda',
+    },
+];


Warning · Non-blocking recommendation

profiles hard-codes Pip and Conda without checking the registered package-manager IDs, so Poetry and future managers can silently lack coverage. Encode every registered manager as either an active fixture or an explicit deferral and assert registry completeness.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:45Z

+
+            await api.managePackages(environment!, { uninstall: ['requests'], runHeadless: true });
+            packages = await api.getPackages(environment!, { skipCache: true });
+            assert.ok(!packages?.some((pkg) => pkg.name === 'requests'), 'Package not uninstalled');


Warning · Non-blocking recommendation

The test first reads packages after installation, so it does not establish that requests was absent or record the claimed uncached baseline. Query with skipCache: true before installation and normalize the starting state before asserting the install transition.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:50Z

GitHub cannot anchor PR review comments to unchanged lines in the diff. Falling back to a general PR comment for src/managers/builtin/pipPackageManager.ts:L85.

Warning · Non-blocking recommendation

A headless manage operation may still display an error prompt if its post-operation package refresh fails through the downstream refresh path. Propagate headless state through that path and add coverage that forces pip list to fail.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:53Z

+            const workspaceFolder = vscode.workspace.workspaceFolders?.[0];
+            assert.ok(workspaceFolder, 'Integration test workspace not found');
+            workspaceUri = workspaceFolder.uri;
+            const config = vscode.workspace.getConfiguration('python-envs', workspaceUri);


Warning · Non-blocking recommendation

The Pip fixture does not force normal Pip execution, so machines with uv enabled may exercise the uv-backed path rather than the intended normal-Pip lifecycle. Pin the relevant setting for this fixture and restore its prior value during teardown.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:55Z

+        suiteTeardown(async () => {
+            try {
+                if (environment) {
+                    await api.removeEnvironment(environment, { runHeadless: true });


Warning · Non-blocking recommendation

Conda removal can resolve after a deletion failure, allowing teardown to pass while leaving the disposable environment behind. Propagate removal failures or verify that the environment no longer exists after cleanup.

Stella Huang (StellaHuang95) · 2026-08-14T22:20:58Z

+
+            await api.refreshEnvironments(workspaceUri);
+
+            environment = await api.createEnvironment(workspaceUri, { quickCreate: true });


Warning · Non-blocking recommendation

Both profiles use the same workspace, allowing project and workspace state to leak between manager lifecycles. Create a distinct disposable project scope per profile and clean it up with the environment.

Stella Huang (StellaHuang95) · 2026-08-14T22:21:01Z

@@ -1091,6 +1119,14 @@ export interface PythonPackageManagerRegistrationApi {
 }

 export interface PythonPackageGetterApi {


Warning · Non-blocking recommendation

Exposing registered manager instances adds a public path around the centralized package-management facade solely for this integration test. Prefer the existing facade or a runtime-gated internal test bridge instead of expanding the public API.

Stella Huang (StellaHuang95) · 2026-08-14T22:21:04Z

+            if (versions === undefined) {
+                this.skip();
+                return;
+            }


Warning · Non-blocking recommendation

Treating every undefined version result as a prerequisite skip can hide command, parsing, or network regressions because managers also map those failures to undefined. Gate known prerequisites before invoking the operation, then fail when an available manager unexpectedly cannot return versions.

Stella Huang (StellaHuang95) · 2026-08-14T22:21:07Z

The sample API contract should also mirror PackageManagementInteractionOptions.runHeadless and PythonPackageGetterApi.getPackageManager from src/api.ts so consumer-facing contracts do not drift.

Stella Huang (StellaHuang95)

Approved via Review Center.

test: cover registered package manager lifecycles (Fixes #1701)

0fa9ad6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

Eduardo Villalpando Mello (edvilme) requested a lite review from Copilot August 7, 2026 23:17

Copilot started reviewing on behalf of Eduardo Villalpando Mello (edvilme) August 7, 2026 23:18 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Comment thread src/test/integration/packageManagement.integration.test.ts Outdated

Comment thread src/test/integration/packageManagement.integration.test.ts Outdated

Comment thread src/test/integration/packageManagement.integration.test.ts Outdated

fix: address review feedback (PR #1704)

596583f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

Eduardo Villalpando Mello (edvilme) requested a lite review from Copilot August 7, 2026 23:59

Copilot started reviewing on behalf of Eduardo Villalpando Mello (edvilme) August 7, 2026 23:59 View session

Copilot AI reviewed Aug 8, 2026

View reviewed changes

Eduardo Villalpando Mello (edvilme) added debt Code quality issues area-package labels Aug 8, 2026

Eduardo Villalpando Mello (edvilme) added 8 commits August 8, 2026 00:34

test: add package manager integration lifecycle

537f5fc

Revert "fix: address review feedback (PR #1704)"

98396c9

This reverts commit 596583f.

Revert "test: cover registered package manager lifecycles (Fixes #1701)"

4d32f1d

This reverts commit 0fa9ad6.

feat: expose registered package manager

bf42d8a

fix: stabilize package manager integration tests

ae5e1d3

Add headless option for PackageManager

fa2f858

Update api version

cb454c9

fix: support headless environment removal

31d186d

Eduardo Villalpando Mello (edvilme) force-pushed the package-manager-integration-coverage branch from 6966031 to 31d186d Compare August 12, 2026 20:46

fix: skip unavailable package version lookup

0078986

Eduardo Villalpando Mello (edvilme) added 2 commits August 13, 2026 17:29

Merge remote-tracking branch 'origin/main' into package-manager-integ…

a8f4e67

…ration-coverage # Conflicts: # api/CHANGELOG.md # api/package-lock.json # api/package.json # src/features/pythonApi.ts

Merge branch 'main' into package-manager-integration-coverage

d6f0a7a

Eduardo Villalpando Mello (edvilme) requested review from Stella Huang (StellaHuang95) and Eleanor Boyd (eleanorjboyd) August 14, 2026 21:53

Stella Huang (StellaHuang95) reviewed Aug 14, 2026

View reviewed changes

Stella Huang (StellaHuang95) approved these changes Aug 14, 2026

View reviewed changes

Stella Huang (StellaHuang95) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 14, 2026


		await api.refreshEnvironments(workspaceUri);

		environment = await api.createEnvironment(workspaceUri, { quickCreate: true });

		@@ -1091,6 +1119,14 @@ export interface PythonPackageManagerRegistrationApi {
		}

		export interface PythonPackageGetterApi {

Uh oh!

Conversation

Eduardo Villalpando Mello (edvilme) commented Aug 7, 2026

Summary

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Stella Huang (StellaHuang95) commented Aug 14, 2026

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) commented Aug 14, 2026

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Stella Huang (StellaHuang95) commented Aug 14, 2026

Uh oh!

Stella Huang (StellaHuang95) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants