Skip to content

Porting K8 fix to release#9987

Merged
IanMatthewHuff merged 2 commits intomicrosoft:release-2020.02from
IanMatthewHuff:dev/ianhu/portK8Fix
Feb 7, 2020
Merged

Porting K8 fix to release#9987
IanMatthewHuff merged 2 commits intomicrosoft:release-2020.02from
IanMatthewHuff:dev/ianhu/portK8Fix

Conversation

@IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Feb 7, 2020

For #9976

Porting this PR:
#9977

To release branch for next week's release.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #9987 into release-2020.02 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2020.02   #9987   +/-   ##
===============================================
  Coverage             61.2%   61.2%           
===============================================
  Files                  564     564           
  Lines                30083   30083           
  Branches              4551    4551           
===============================================
  Hits                 18411   18411           
  Misses               10642   10642           
  Partials              1030    1030
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 67.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4946e5c...36958f7. Read the comment docs.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Feb 7, 2020
@IanMatthewHuff
Copy link
Member Author

IanMatthewHuff commented Feb 7, 2020

npm ci fails in CI

@IanMatthewHuff IanMatthewHuff reopened this Feb 7, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IanMatthewHuff IanMatthewHuff merged commit 3be03b0 into microsoft:release-2020.02 Feb 7, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/portK8Fix branch February 7, 2020 21:59
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IanMatthewHuff @codecov-io @rchiodo @DavidKutu @tom-shan