Skip to content

add the ip argument of jupyter server for k8s container #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rchiodo merged 1 commit into from
Feb 7, 2020
Merged

add the ip argument of jupyter server for k8s container #9977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/9976.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add --ip=127.0.0.1 argument of jupyter server when running in k8s container
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/notebookStarter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export class NotebookStarter implements Disposable {
// Check for a docker situation.
try {
const cgroup = await this.fileSystem.readFile('/proc/self/cgroup').catch(() => '');
if (!cgroup.includes('docker')) {
if (!cgroup.includes('docker') && !cgroup.includes('kubepods')) {
return args;
}
// We definitely need an ip address.
Expand Down