Disables the use of a terminal to activate an environment#9967
Merged
DonJayamanne merged 3 commits intomicrosoft:masterfrom Feb 7, 2020
Merged
Conversation
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
karthiknadig and
rchiodo
rchiodo
approved these changes
Feb 6, 2020
IanMatthewHuff
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #9967 +/- ##
=========================================
- Coverage 61.2% 61.2% -0.01%
=========================================
Files 564 564
Lines 30078 30083 +5
Branches 4550 4550
=========================================
+ Hits 18408 18411 +3
- Misses 10640 10642 +2
Partials 1030 1030
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Feb 6, 2020
DonJayamanne
added a commit
that referenced
this pull request
Feb 7, 2020
* Disables the use of a terminal to activate an environment * Fix tests * Fix linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily disabled until we update to use the latest VSC API.
(also reading files unnecessarily instead of caching it)
Basically this code restores the old behaviour.