Skip to content

Run tests against insiders #9872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Feb 3, 2020
Merged

Run tests against insiders #9872

DonJayamanne merged 3 commits into from
Feb 3, 2020

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 3, 2020

No description provided.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 3, 2020
@DonJayamanne
Copy link
Author

DonJayamanne commented Feb 3, 2020

Duh, CI hence close and reopen..

@DonJayamanne DonJayamanne reopened this Feb 3, 2020
@DonJayamanne
Copy link
Author

DonJayamanne commented Feb 3, 2020

@IanMatthewHuff @rchiodo I'll remove the commented code from the redux logger. it was just adding too much stuff for me ..
Will remove once PR is approved. looks like all tests are going smoothly, functional tests and others as well.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@7ff3ed6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor    #9872   +/-   ##
===================================================
  Coverage                    ?   60.64%           
===================================================
  Files                       ?      555           
  Lines                       ?    29726           
  Branches                    ?     4479           
===================================================
  Hits                        ?    18028           
  Misses                      ?    10697           
  Partials                    ?     1001

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff3ed6...642b733. Read the comment docs.

rchiodo
rchiodo reviewed Feb 3, 2020
View reviewed changes
src/datascience-ui/interactive-common/redux/store.ts Outdated
});
const loggerMiddleware = process.env.VSC_PYTHON_FORCE_LOGGING !== undefined || (process.env.NODE_ENV !== 'production' && !testMode) ? logger : undefined;

// const loggerMiddleware = process.env.VSC_PYTHON_FORCE_LOGGING !== undefined || (process.env.NODE_ENV !== 'production' && !testMode) ? logger : undefined;
Copy link

@rchiodo rchiodo Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to remove this?

Copy link

@rchiodo rchiodo Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, saw your comment now.

@DonJayamanne DonJayamanne merged commit bb95b58 into microsoft:ds/custom_editor Feb 3, 2020
@DonJayamanne DonJayamanne deleted the runTestsAgainstInsiders branch February 3, 2020 21:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lock lock bot locked as resolved and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo