Skip to content

Add telemetry for failed activation and searching kernel - #9158

Merged
Don Jayamanne (DonJayamanne) merged 6 commits into
microsoft:masterfrom
DonJayamanne:addMoreTelemetry
Dec 17, 2019
Merged

Add telemetry for failed activation and searching kernel#9158
Don Jayamanne (DonJayamanne) merged 6 commits into
microsoft:masterfrom
DonJayamanne:addMoreTelemetry

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Dec 17, 2019

Copy link
Copy Markdown

For #8866

  • Telemetry for failures to get activated env variables
  • Telemetry for searching local kernels/interpreters
  • Increase time to search for a new kernel (spawning procs on windows can take around 4s).

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 17, 2019
@codecov-io

Codecov (codecov-io) commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9158 into master will decrease coverage by 0.26%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9158      +/-   ##
==========================================
- Coverage    57.4%   57.14%   -0.27%     
==========================================
  Files         551      551              
  Lines       29262    29313      +51     
  Branches     4438     4439       +1     
==========================================
- Hits        16799    16750      -49     
- Misses      11528    11624      +96     
- Partials      935      939       +4
Impacted Files Coverage Δ
src/client/telemetry/index.ts 86.48% <ø> (ø) ⬆️
src/client/datascience/constants.ts 99.67% <100%> (ø) ⬆️
src/client/datascience/jupyter/jupyterSession.ts 67.17% <100%> (+0.34%) ⬆️
src/client/telemetry/constants.ts 100% <100%> (ø) ⬆️
src/client/interpreter/activation/service.ts 87.5% <100%> (+0.61%) ⬆️
...lient/datascience/jupyter/kernels/kernelService.ts 60.71% <100%> (ø) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 12.5% <100%> (-1.64%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 74.56% <87.5%> (+0.72%) ⬆️
src/client/testing/serviceRegistry.ts 49.09% <0%> (-47.28%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-30%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31b8bf...1bea11d. Read the comment docs.

@DonJayamanne

Don Jayamanne (DonJayamanne) commented Dec 17, 2019

Copy link
Copy Markdown
Author

Rich Chiodo (@rchiodo) Ian Huff (@IanMatthewHuff) Please re-review (specifically changes to capturing time taken to wait for idle. We were missing a few places where waitForIdle was called)

rchiodo
Rich Chiodo (rchiodo) approved these changes Dec 17, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
Ian Huff (IanMatthewHuff) approved these changes Dec 17, 2019
View reviewed changes

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 9976f85 into microsoft:master Dec 17, 2019
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Dec 17, 2019
@DonJayamanne
Add telemetry for failed activation and searching kernel (#9158)
4e0fdc5 
* Add some telemetry
* Fix linter
* Changes to wait for idle
* Remove
* Fix linter
* Increase timeout
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the addMoreTelemetry branch April 30, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo