Skip to content

Restart live kernel instead of starting a new session - #9150

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:fixRemoteKernelRestart
Dec 17, 2019
Merged

Restart live kernel instead of starting a new session#9150
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:fixRemoteKernelRestart

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Dec 17, 2019

Copy link
Copy Markdown

For #8866

  • When connected to a remote session and user restarts a kernel, we should not be switching to the restart session instead we need to restart the kernel.

@codecov-io

Codecov (codecov-io) commented Dec 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9150 into master will increase coverage by 0.39%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9150      +/-   ##
=========================================
+ Coverage   57.01%   57.4%   +0.39%     
=========================================
  Files         551     551              
  Lines       29258   29262       +4     
  Branches     4436    4438       +2     
=========================================
+ Hits        16680   16799     +119     
+ Misses      11662   11528     -134     
- Partials      916     935      +19
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterSession.ts 66.83% <80%> (+60.49%) ⬆️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 100% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8bf17...8c427bb. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit b31b8bf into microsoft:master Dec 17, 2019
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Dec 17, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the fixRemoteKernelRestart branch December 17, 2019 17:28
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants