Switch to remote session instead of switching kernels - #9147
Merged
Don Jayamanne (DonJayamanne) merged 11 commits intoDec 17, 2019
Merged
Switch to remote session instead of switching kernels#9147Don Jayamanne (DonJayamanne) merged 11 commits into
Don Jayamanne (DonJayamanne) merged 11 commits into
Conversation
Don Jayamanne (DonJayamanne)
requested review from
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
December 16, 2019 23:51
Codecov Report
@@ Coverage Diff @@
## master #9147 +/- ##
=========================================
- Coverage 57.05% 57% -0.05%
=========================================
Files 551 551
Lines 29228 29258 +30
Branches 4430 4436 +6
=========================================
+ Hits 16676 16679 +3
- Misses 11638 11663 +25
- Partials 914 916 +2
Continue to review full report at Codecov.
|
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Dec 17, 2019
For #8866 When selecting a remote session, connect to that session instead of connecting to that kernel. If we connect to a kernel, the API shutdowns the previously connected kernel. With the new changes, when selecting a remote kernel, we're in-fact selecting a remote session that we connect to. However the API is still indicates we're connecting to a kernel (however under the hoods we connect to a session).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8866
When selecting a remote session, connect to that session instead of connecting to that kernel.
If we connect to a kernel, the API shutdowns the previously connected kernel.
With the new changes, when selecting a remote kernel, we're in-fact selecting a remote session that we connect to.
However the API is still indicates we're connecting to a kernel (however under the hoods we connect to a session).