Skip to content

Add ability to start a new kernel when in a remote session - #9144

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:remoteSelectNewKernel
Dec 16, 2019
Merged

Add ability to start a new kernel when in a remote session#9144
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:remoteSelectNewKernel

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #8866

@codecov-io

Codecov (codecov-io) commented Dec 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9144 into master will increase coverage by 0.66%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9144      +/-   ##
==========================================
+ Coverage   56.39%   57.05%   +0.66%     
==========================================
  Files         551      551              
  Lines       28840    29228     +388     
  Branches     4427     4430       +3     
==========================================
+ Hits        16264    16676     +412     
+ Misses      11662    11638      -24     
  Partials      914      914
Impacted Files Coverage Δ
...nt/datascience/jupyter/kernels/kernelSelections.ts 91.66% <75%> (-0.99%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 73.83% <0%> (-1.42%) ⬇️
src/client/datascience/jupyter/jupyterExecution.ts 51.97% <0%> (-0.7%) ⬇️
...lient/datascience/jupyter/jupyterSessionManager.ts 9.63% <0%> (-0.12%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 6.52% <0%> (-0.11%) ⬇️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/dotnet/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1e3c7...0a0e3d2. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 6004e8c into microsoft:master Dec 16, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the remoteSelectNewKernel branch December 16, 2019 22:58
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Dec 16, 2019
* Add ability to start a new kernel
* Fixed tests
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants