Hide the restart session kernels from kernel picker - #9137
Merged
Don Jayamanne (DonJayamanne) merged 7 commits intoDec 16, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9137 +/- ##
==========================================
- Coverage 56.39% 56.38% -0.02%
==========================================
Files 551 551
Lines 28840 28854 +14
Branches 4427 4429 +2
==========================================
+ Hits 16264 16268 +4
- Misses 11662 11679 +17
+ Partials 914 907 -7
Continue to review full report at Codecov.
|
Don Jayamanne (DonJayamanne)
requested review from
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
December 16, 2019 18:57
Don Jayamanne (DonJayamanne)
marked this pull request as ready for review
December 16, 2019 18:57
Don Jayamanne (DonJayamanne)
force-pushed
the
hideKernels
branch
from
December 16, 2019 19:12
5b740a0 to
99e0c7e
Compare
Don Jayamanne (DonJayamanne)
requested a review
from Ian Huff (IanMatthewHuff)
December 16, 2019 21:29
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Dec 16, 2019
* Hide the restart session kernels * Add tests * Fix linter * Fix tests * Fix tests * Address code reviews * Fix linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8866