Skip to content

Add progress indicator when switching kernels - #9134

Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:addKernelSwitcherProgress
Dec 16, 2019
Merged

Add progress indicator when switching kernels#9134
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:addKernelSwitcherProgress

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #8866

@codecov-io

Codecov (codecov-io) commented Dec 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9134 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9134      +/-   ##
==========================================
- Coverage   57.07%   57.06%   -0.01%     
==========================================
  Files         551      551              
  Lines       29203    29210       +7     
  Branches     4424     4427       +3     
==========================================
+ Hits        16667    16669       +2     
- Misses      11622    11627       +5     
  Partials      914      914
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 94.69% <100%> (+0.01%) ⬆️
.../datascience/interactive-common/interactiveBase.ts 18.15% <9.09%> (-0.18%) ⬇️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ea8e8...72ef028. Read the comment docs.

Comment thread src/client/datascience/interactive-common/interactiveBase.ts Outdated
@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 16, 2019

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 30d50bb into microsoft:master Dec 16, 2019
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Dec 16, 2019
* Add progress indicator when switching kernels
* Oops
* Typo
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the addKernelSwitcherProgress branch December 17, 2019 17:28
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants