Skip to content

Fix bug in registering interpreter as kernel and add telemetry for DS events - #9052

Merged
Don Jayamanne (DonJayamanne) merged 5 commits into
microsoft:masterfrom
DonJayamanne:addTelemetryDS
Dec 12, 2019
Merged

Fix bug in registering interpreter as kernel and add telemetry for DS events#9052
Don Jayamanne (DonJayamanne) merged 5 commits into
microsoft:masterfrom
DonJayamanne:addTelemetryDS

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #8866

  • Once ipykernel is installed we didn't register the kernel
  • Added telemetry to track usage of kernel switcher and types of kernels created/selected.

@codecov-io

Codecov (codecov-io) commented Dec 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9052 into master will increase coverage by 0.04%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9052      +/-   ##
==========================================
+ Coverage   57.07%   57.12%   +0.04%     
==========================================
  Files         551      551              
  Lines       29075    29099      +24     
  Branches     4392     4394       +2     
==========================================
+ Hits        16596    16623      +27     
+ Misses      11573    11569       -4     
- Partials      906      907       +1
Impacted Files Coverage Δ
src/client/telemetry/index.ts 86.48% <ø> (ø) ⬆️
src/client/datascience/constants.ts 99.67% <100%> (ø) ⬆️
...lient/datascience/jupyter/kernels/kernelService.ts 60.71% <75%> (+3.48%) ⬆️
...ient/datascience/jupyter/kernels/kernelSelector.ts 86.95% <83.33%> (+1.71%) ⬆️
...nt/datascience/jupyter/kernels/kernelSelections.ts 93.65% <0%> (-2.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1767a...4e52746. Read the comment docs.

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 12, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 85262e9 into microsoft:master Dec 12, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the addTelemetryDS branch December 17, 2019 17:30
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants