Disable kernel selector under certain circumstances - #9031
Merged
Don Jayamanne (DonJayamanne) merged 5 commits intoDec 12, 2019
Merged
Disable kernel selector under certain circumstances#9031Don Jayamanne (DonJayamanne) merged 5 commits into
Don Jayamanne (DonJayamanne) merged 5 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9031 +/- ##
==========================================
+ Coverage 56.98% 57.07% +0.09%
==========================================
Files 550 551 +1
Lines 28959 29075 +116
Branches 4376 4392 +16
==========================================
+ Hits 16502 16596 +94
- Misses 11563 11573 +10
- Partials 894 906 +12
Continue to review full report at Codecov.
|
| let selectorCalled = false; | ||
| runMountedTest('Select Jupyter Kernel', async (_wrapper) => { | ||
| console.log('Tests skipped, as we need better tests') | ||
| // let selectorCalled = false; |
There was a problem hiding this comment.
Skipping:
- We dont have tests to test status changes
- Feels too complicated to test a small component
- Test small component individually
- In functional test, ensure right state (props) are passed to this (this way we test integration as well)
There was a problem hiding this comment.
Would take more time to add tests for this, need to move onto other PRs.
Don Jayamanne (DonJayamanne)
marked this pull request as ready for review
December 12, 2019 16:48
Rich Chiodo (rchiodo)
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8866
Disable the kernel picker UI element if Jupyter server hasn't been started or while in the middle of restarting or starting a kernel.