Skip to content

Prefetch and cache kernel specs for faster kernel selection ui - #9025

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:cacheKernelSpecs
Dec 12, 2019
Merged

Prefetch and cache kernel specs for faster kernel selection ui#9025
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:cacheKernelSpecs

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #8866

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 11, 2019
@DonJayamanne Don Jayamanne (DonJayamanne) changed the title Prefetch and cache kernel specs for kernel selection ui Prefetch and cache kernel specs for faster kernel selection ui Dec 11, 2019
@codecov-io

Codecov (codecov-io) commented Dec 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9025 into master will increase coverage by <.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9025      +/-   ##
==========================================
+ Coverage   57.07%   57.08%   +<.01%     
==========================================
  Files         551      551              
  Lines       29075    29086      +11     
  Branches     4392     4394       +2     
==========================================
+ Hits        16596    16605       +9     
  Misses      11573    11573              
- Partials      906      908       +2
Impacted Files Coverage Δ
...ient/datascience/jupyter/kernels/kernelSelector.ts 85.71% <100%> (+0.46%) ⬆️
...nt/datascience/jupyter/kernels/kernelSelections.ts 93.65% <83.33%> (-2.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1767a...9e0fa4b. Read the comment docs.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 85e9721 into microsoft:master Dec 12, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the cacheKernelSpecs branch December 17, 2019 17:28
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants