Skip to content

Add title for the kernel selector - #9024

Merged
Don Jayamanne (DonJayamanne) merged 12 commits into
microsoft:masterfrom
DonJayamanne:fixKernelPicker
Dec 12, 2019
Merged

Add title for the kernel selector#9024
Don Jayamanne (DonJayamanne) merged 12 commits into
microsoft:masterfrom
DonJayamanne:fixKernelPicker

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Dec 11, 2019

Copy link
Copy Markdown

For #8866

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 11, 2019
rchiodo
Rich Chiodo (rchiodo) reviewed Dec 11, 2019
View reviewed changes
Comment thread src/client/datascience/jupyter/kernels/kernelSelector.ts
rchiodo
Rich Chiodo (rchiodo) previously approved these changes Dec 11, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rchiodo
Rich Chiodo (rchiodo) approved these changes Dec 11, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io

Codecov (codecov-io) commented Dec 11, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9024 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9024      +/-   ##
==========================================
+ Coverage   57.08%   57.08%   +<.01%     
==========================================
  Files         551      551              
  Lines       29071    29070       -1     
  Branches     4390     4389       -1     
==========================================
  Hits        16595    16595              
  Misses      11569    11569              
+ Partials      907      906       -1
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 94.63% <100%> (ø) ⬆️
...nt/datascience/jupyter/kernels/kernelSelections.ts 96.29% <85.71%> (-1.79%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 85.24% <91.66%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048897c...7b49ded. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 1c1767a into microsoft:master Dec 12, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the fixKernelPicker branch December 17, 2019 17:28
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes
@IanMatthewHuff Ian Huff (IanMatthewHuff) Awaiting requested review from IanMatthewHuff

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @codecov-io @rchiodo